refactor(execution/grpc): move execution service where it belongs#3302
Merged
julienrbrt merged 3 commits intomainfrom Apr 29, 2026
Merged
refactor(execution/grpc): move execution service where it belongs#3302julienrbrt merged 3 commits intomainfrom
julienrbrt merged 3 commits intomainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughRelocates protobuf type generation and imports for gRPC execution services from top-level Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Contributor
|
Claude Code is working… I'll analyze this and get back to you. |
Contributor
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3302 +/- ##
==========================================
- Coverage 62.72% 60.55% -2.17%
==========================================
Files 124 126 +2
Lines 13248 13721 +473
==========================================
- Hits 8310 8309 -1
- Misses 4034 4508 +474
Partials 904 904
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tac0turtle
approved these changes
Apr 29, 2026
Member
Author
|
will fix the linting issue before merging. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CHANGELOG.md`:
- Around line 16-18: The changelog contains an empty markdown link token "[]()"
in the list item "Move execution service where it belongs in execution/grpc.
[]()"; remove the empty link or replace it with the correct PR reference (e.g.,
add the PR number and URL) so the line reads without a broken link; update the
same list item in CHANGELOG.md by editing the text "Move execution service where
it belongs in execution/grpc. []()" to either "Move execution service where it
belongs in execution/grpc." or "Move execution service where it belongs in
execution/grpc. [`#PR_NUMBER`](PR_URL)".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7ef2bafb-da54-40bc-aaaf-56f49e01f144
⛔ Files ignored due to path filters (2)
execution/grpc/go.sumis excluded by!**/*.sumexecution/grpc/types/pb/evnode/v1/execution.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (13)
.just/proto.justCHANGELOG.mdbuf.gen.grpc.yamlbuf.yamlexecution/grpc/client.goexecution/grpc/go.modexecution/grpc/handler.goexecution/grpc/proto/evnode/v1/execution.protoexecution/grpc/server.goexecution/grpc/server_test.goexecution/grpc/tx_batch.goexecution/grpc/tx_batch_test.goexecution/grpc/types/pb/evnode/v1/v1connect/execution.connect.go
💤 Files with no reviewable changes (1)
- execution/grpc/go.mod
Comment on lines
+16
to
+18
| - **BREAKING:** (execution/grpc) | ||
| - Move execution service where it belongs in execution/grpc. []() | ||
| - Replace legacy gRPC execution `txs` payload fields with `tx_batch` so clients and servers use contiguous transaction buffers [#3297](https://github.com/evstack/ev-node/pull/3297) |
Contributor
There was a problem hiding this comment.
Fix the empty markdown link.
[]() on Line 17 will trip markdownlint and renders as a broken changelog entry. Replace it with the actual PR reference or remove the link syntax.
Suggested fix
- - Move execution service where it belongs in execution/grpc. []()
+ - Move execution service where it belongs in execution/grpc. [`#3302`](https://github.com/evstack/ev-node/pull/3302)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - **BREAKING:** (execution/grpc) | |
| - Move execution service where it belongs in execution/grpc. []() | |
| - Replace legacy gRPC execution `txs` payload fields with `tx_batch` so clients and servers use contiguous transaction buffers [#3297](https://github.com/evstack/ev-node/pull/3297) | |
| - **BREAKING:** (execution/grpc) | |
| - Move execution service where it belongs in execution/grpc. [`#3302`](https://github.com/evstack/ev-node/pull/3302) | |
| - Replace legacy gRPC execution `txs` payload fields with `tx_batch` so clients and servers use contiguous transaction buffers [`#3297`](https://github.com/evstack/ev-node/pull/3297) |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 17-17: No empty links
(MD042, no-empty-links)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CHANGELOG.md` around lines 16 - 18, The changelog contains an empty markdown
link token "[]()" in the list item "Move execution service where it belongs in
execution/grpc. []()"; remove the empty link or replace it with the correct PR
reference (e.g., add the PR number and URL) so the line reads without a broken
link; update the same list item in CHANGELOG.md by editing the text "Move
execution service where it belongs in execution/grpc. []()" to either "Move
execution service where it belongs in execution/grpc." or "Move execution
service where it belongs in execution/grpc. [`#PR_NUMBER`](PR_URL)".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #3297 implements #3297 (review)